Add required Impression and MediaFile/@delivery to Tremor VAST 2.0 samples - #47
Open
aleksUIX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #45. Two Tremor VAST 2.0 files did not validate against
vast_2.0.1.xsd:vast2Nonlinear.xml: 10<InLine>ads, no<Impression>on any of them (minOccurs=1)vast2VPAIDLinear.xml: same missing<Impression>, plus the SWF<MediaFile>omitted required@deliveryThese are the only
version="2.0"files in the repo that failed that schema. The rest of the Tremor 2.0 set already has both fields.vast2RegularLinear.xmlin the same folder is the model:Impressionimmediately afterAdTitle,delivery="progressive"onMediaFile.Fix
Copied that sibling
Impression(includingid="blah"and the existing ScanScout CDATA URL) onto every InLine in the two files. Addeddelivery="progressive"on the VPAID SWF. No other edits: creative URLs, companions, and ad ids are unchanged.Test plan
Against vast_2.0.1.xsd:
vast2RegularLinear.xmlstill validatesversion="2.0"XML files in this repo validate; 0 failuresCloses #45