Fix duplicate package name in initialization backtrace - #1720
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughPackage-qualified signature construction now formats package initialization roots without duplicating the package name. A DBMS_UTILITY regression test covers schema-qualified package initialization failures and validates the resulting backtrace. ChangesPackage initialization backtrace
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR makes a localized backtrace-formatting fix with regression coverage and no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for your contribution! |
Summary
FORMAT_ERROR_BACKTRACEValidation
make -C src/include allmake -C src/pl/plisql/src pl_exec.ogit diff --checkA full Cygwin build was also attempted. It reached the unchanged
src/backend/oracle_parsertarget, where linkingliboracle_parser.dllfailed on the existingOraScanKeywordTokensimport symbol, so the regression suite could not be started in this environment.Fixes #1710
Summary by CodeRabbit
Bug Fixes
Tests