Fix maintainer-clean for subsequent Meson builds

[yyqdbngt]

Summary

• make the top-level maintainer-clean remove IvorySQL-generated parser and scanner sources that conflict with out-of-tree Meson builds
• include the generated Oracle parser header in its local maintainer-clean target
• make libpq distclean remove the configure-generated ivy_sema.c while preserving normal clean behavior

Validation

• configured an Autoconf build and generated all affected IvorySQL parser/scanner files
• ran make maintainer-clean and verified all listed generated files, src/interfaces/libpq/ivy_sema.c, src/include/pg_config.h, and the top-level GNUmakefile were removed
• ran a fresh out-of-tree setup with Meson 1.8.3; the source/build conflict check passed and configuration completed with 477 targets
• git diff --check

Fixes #1709

Summary by CodeRabbit

• Chores
  • Added a maintainer cleanup option that removes generated parser, scanner, grammar, keyword, and error-code files.
  • Enhanced cleanup for the Oracle parser by removing an additional generated header.
  • Improved library cleanup commands, including removal of generated semantic-analysis files during deep cleanup.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c6e79470-58eb-4518-b40b-ed308413d922

📥 Commits

Reviewing files that changed from the base of the PR and between ef914ad and 34698a6.

📒 Files selected for processing (3)

• GNUmakefile.in
• src/backend/oracle_parser/Makefile
• src/interfaces/libpq/Makefile

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The Makefiles now provide a top-level maintainer-clean target. Local distclean targets remove additional generated files, including ora_gram.h and ivy_sema.c.

Changes

Generated artifact cleanup

Layer / File(s)	Summary
Local cleanup target separation src/interfaces/libpq/Makefile, src/backend/oracle_parser/Makefile	libpq separates clean from distclean and removes ivy_sema.c during distclean. The Oracle parser cleanup removes ora_gram.h.
Top-level maintainer cleanup GNUmakefile.in	Adds maintainer-clean, which depends on distclean and removes generated files in Oracle parser, frontend utility, isolation-test, and PL/ISQL directories.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 34698

The change is localized to generated-file cleanup for Autoconf and Meson builds, with the documented validation passing; no actionable merge-blocking risk remains.

Possibly related PRs

• IvorySQL/IvorySQL#1475: Both changes address handling of generated ivy_sema.c in src/interfaces/libpq/Makefile.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing maintainer-clean behavior for subsequent Meson builds.
Linked Issues check	✅ Passed	The changes remove the generated files identified in issue #1709, enabling a clean source tree for subsequent Meson setup.
Out of Scope Changes check	✅ Passed	All changes support the linked issue by extending cleanup targets and removing generated files; no unrelated changes are identified.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[NotHimmel]

Thanks for your contribution!