Skip to content

Update version number to 0.3.5 - #103

Open
JeremyCCHsu wants to merge 5 commits into
masterfrom
misc035
Open

Update version number to 0.3.5#103
JeremyCCHsu wants to merge 5 commits into
masterfrom
misc035

Conversation

@JeremyCCHsu

@JeremyCCHsu JeremyCCHsu commented Jan 20, 2025

Copy link
Copy Markdown
Owner

No description provided.

@sabonerune sabonerune mentioned this pull request Jan 21, 2025
Open
@JeremyCCHsu

JeremyCCHsu commented Jan 21, 2025

Copy link
Copy Markdown
Owner Author

Hey @sabonerune, thanks for #99. I tested it, but it seems that older Python doesn't have importlib_metadata out of the box. Therefore, I created this PR and keep pkg_resources instead for the version number. Let me know if that makes sense or if there are any suggestions.

@sabonerune

sabonerune commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

@JeremyCCHsu
I think in most cases using pkg_resources with Python < 3.8 is probably fine.
This is because Setuptools is typically expected to be installed by default on these versions.
Also, since Setuptools has dropped support for these Python versions, there is no need to worry about the API being broken.

It would be a problem if users manually uninstalled Setuptools, but I don't think they would normally do that.

@sabonerune

sabonerune commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

@JeremyCCHsu
I recently learned that setuptools is not installed in the virtual environment created by the package manager uv.

Also, the sdist released on pypi seems to be a different source code than the wheel.
This makes it more likely that errors like ModuleNotFoundError: No module named 'pkg_resources' will occur in environments other than Windows.

@agonzalezd

agonzalezd commented Jul 30, 2025

Copy link
Copy Markdown

@sabonerune @JeremyCCHsu
I found the ModuleNotFoundError: No module named 'pkg_resources' error in Docker image python:3.12 when importing after installing it

JeremyCCHsu added a commit that referenced this pull request Aug 18, 2026
@JeremyCCHsu
Merge requests from open PRs (#96, #99, #103, #104, #105, #106)
8796e0d 
- Add PEP 561 type stubs (pyworld/pyworld.pyi, pyworld/py.typed) and package_data in setup.py (#104, #105)
- Migrate from pkg_resources to importlib.metadata with fallback (#99, #103)
- Add Cython <3.1.0 constraint for Python <3.9 in pyproject.toml (#106)
- Clean requirements.txt to core dependencies and update AppVeyor demo setup (#103)
- Add sabonerune to README acknowledgements (#103)
@JeremyCCHsu JeremyCCHsu mentioned this pull request Aug 19, 2026
Merged
JeremyCCHsu added a commit that referenced this pull request Aug 20, 2026
@JeremyCCHsu
Resolve all existing PRs (#109)
f31ad88 
* Update lib/World submodule to latest commit, bump version to 0.3.6, fix Cython syntax

* Merge requests from open PRs (#96, #99, #103, #104, #105, #106)
- Add PEP 561 type stubs (pyworld/pyworld.pyi, pyworld/py.typed) and package_data in setup.py (#104, #105)
- Migrate from pkg_resources to importlib.metadata with fallback (#99, #103)
- Add Cython <3.1.0 constraint for Python <3.9 in pyproject.toml (#106)
- Clean requirements.txt to core dependencies and update AppVeyor demo setup (#103)
- Add sabonerune to README acknowledgements (#103)

* add 3.12 & 3.13 tests

* Pin libsndfile version for Py 3.6/3.7

* Another attempt to fix 3.6/3.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeremyCCHsu @sabonerune @agonzalezd