ENH: Add stub file. - #104
Open
sabonerune wants to merge 1 commit into
Open
Conversation
sabonerune
commented
Apr 29, 2025
sabonerune
left a comment
sabonerune
left a comment
Contributor
Author
There was a problem hiding this comment.
A simple type hint that's better than nothing.
| @@ -0,0 +1,399 @@ | |||
| from typing import Optional, Tuple | |||
Contributor
Author
There was a problem hiding this comment.
typing.Tuple is Deprecated.
However, removing this requires Python 3.9 (or maybe Python 3.7).
https://docs.python.org/3.13/library/typing.html#typing.Tuple
| cmdclass={'build_ext': build_ext}, | ||
| version=_VERSION, | ||
| packages=find_packages(), | ||
| package_data={"": ["py.typed", "*.pyi"]}, |
Contributor
Author
There was a problem hiding this comment.
If setuptools>=v69.0.0 this code is not needed.
https://setuptools.pypa.io/en/latest/history.html#id256
But this is only supported in Python >= 3.8.
Contributor
Author
There was a problem hiding this comment.
Typing of ndarrays is minimal.
It would be great if we could type hint it like this:
def synthesize(
f0: np.ndarray[tuple[int], np.dtype[np.double]],
spectrogram: np.ndarray[tuple[int, int], np.dtype[np.double]],
aperiodicity: np.ndarray[tuple[int, int], np.dtype[np.double]],
fs: int,
frame_period: float
) -> np.ndarray[tuple[int], np.dtype[np.double]]:...But this is probably supported in numpy>=1.22 and Python>=3.9.
Python 3.10 supports Numpy 1.21.6, so it wouldn't be easy to add it without dropping one of them.
JeremyCCHsu
added a commit
that referenced
this pull request
Aug 18, 2026
- Add PEP 561 type stubs (pyworld/pyworld.pyi, pyworld/py.typed) and package_data in setup.py (#104, #105) - Migrate from pkg_resources to importlib.metadata with fallback (#99, #103) - Add Cython <3.1.0 constraint for Python <3.9 in pyproject.toml (#106) - Clean requirements.txt to core dependencies and update AppVeyor demo setup (#103) - Add sabonerune to README acknowledgements (#103)
JeremyCCHsu
added a commit
that referenced
this pull request
Aug 20, 2026
* Update lib/World submodule to latest commit, bump version to 0.3.6, fix Cython syntax * Merge requests from open PRs (#96, #99, #103, #104, #105, #106) - Add PEP 561 type stubs (pyworld/pyworld.pyi, pyworld/py.typed) and package_data in setup.py (#104, #105) - Migrate from pkg_resources to importlib.metadata with fallback (#99, #103) - Add Cython <3.1.0 constraint for Python <3.9 in pyproject.toml (#106) - Clean requirements.txt to core dependencies and update AppVeyor demo setup (#103) - Add sabonerune to README acknowledgements (#103) * add 3.12 & 3.13 tests * Pin libsndfile version for Py 3.6/3.7 * Another attempt to fix 3.6/3.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's almost a copy of
pyworld.pyx.Features are minimal to support older Python and Numpy.