Implement PyDenseArray - #821
Open
JamesWrigley wants to merge 1 commit into
Open
JamesWrigley wants to merge 1 commit into
JamesWrigley wants to merge 1 commit into
Conversation
This is a minimal array type to allow dispatching to things like BLAS functions that require `DenseArray`.
JamesWrigley
force-pushed
the
pydensearray
branch
from
September 14, 2026 22:29
22a6965 to
fa834a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal array type to allow dispatching to things like BLAS functions that require
DenseArray, inspired by the idea proposed in #319 (comment). Example performance improvement:I think this makes more sense than a
DenseViewtype in a separate package because this way in v1 we can make it the default instead ofPyArraywhen converting contiguous arrays. Which would be very nice for performance :) It ended up being a fairly small amount of code since it's such a restricted type, so hopefully it's not too much of a maintenance burden.Written with help from Claude 🤖