fix(graph): complete absent residual provenance cleanup - #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defect
Foreground graph view removal captures v2 provenance evidence, commits durable residual cleanup authority, and then removes the exact sidecar. When residual maintenance later reached provenance, the missing sidecar read as legacy-unknown and was retried forever as invalid-sidecar.
Safety
The new terminal path requires a syntactically valid stored token for the exact checkout and worktree plus a containment-safe current absence proof under the shared provenance lock. Existing legacy-v1, invalid, symlinked, replacement, permission-ambiguous, or containment-ambiguous state remains preserved or deferred.
Verification
Property-testing assessment: no new property was added because this is one exact two-stage regression; existing removed-view worker properties already cover generalized phase and retry transitions.
Global development install is intentionally deferred while the Threadnote 4.4 release worktree owns the singleton runtime.