Skip to content

fix: incorrect Boolean.getBoolean usage in ScepConfiguration - #1067

Open
CiiLu wants to merge 2 commits into
Keyfactor:mainfrom
CiiLu:boolean-parsing
Open

fix: incorrect Boolean.getBoolean usage in ScepConfiguration#1067
CiiLu wants to merge 2 commits into
Keyfactor:mainfrom
CiiLu:boolean-parsing

Conversation

@CiiLu

@CiiLu CiiLu commented Aug 12, 2026

Copy link
Copy Markdown

Describe your changes

ScepConfiguration currently uses Boolean#getBoolean , that reads the given string as a property name and the looks at what the value of that property is and parse it.It didn't parse the given value to boolean.

It leads that some invoke returns unexpected value.

Such as

return Boolean.getBoolean(DEFAULT_CLIENT_CERTIFICATE_RENEWAL);

expected true, actually false'

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have kept the patch limited to only change the parts related to the patch
  • This change requires a documentation update

See also Contributing Guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant