Skip to content

Add EXT_abort - #317

Open
r-potter wants to merge 2 commits into
KhronosGroup:mainfrom
r-potter:EXT_abort
Open

r-potter wants to merge 2 commits into
KhronosGroup:mainfrom
r-potter:EXT_abort

Conversation

@r-potter

Copy link
Copy Markdown

cc @gnl21

@arcady-lunarg

Copy link
Copy Markdown

Can this be merged? It's already implemented in glslang.

@rdb

rdb commented Jun 28, 2026

Copy link
Copy Markdown

One grammar question: like GL_EXT_debug_printf, this extension doesn't actually define a syntactic path to allow a literal string in a function-call argument. The wording ("the first argument must be a literal string") suggests the string is a special argument rather than an expression; yet glslang parses strings as a primary-expression, so abortEXT(("foo")) is accepted by glslang even though nothing in this extension suggests that it should be.

So: what is actually intended here? I would like to know so that so that the grammar I have proposed in GL_EXT_spirv_intrinsics_string (#333) can be kept consistent with what GL_EXT_abort and GL_EXT_debug_printf do. Adding an explicit production to the extension text may be useful to remove any ambiguity.

Also, minor typo: "Last Modified Date" mentions "September 31, 2024", even though September has only 30 days.

@jeffbolznv

Copy link
Copy Markdown
Contributor

I think you're right that there is a missing edit to the grammar, that ("foo") should not be treated as a literal string, and that glslang is missing validation for this for debugPrintf (and presumably also for abort, but I haven't looked).

Comment thread extensions/ext/GLSL_EXT_abort.txt Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants