Normalize line endings and clean up Docker build inputs

.gitattributes

@@ -1 +1,7 @@
 * text=auto
+
+# Files under a files/ directory are COPY'd into Docker images and
+# run/sourced as Unix scripts. Force LF line endings on checkout so a
+# fresh enlistment is always correct, regardless of the checkout
+# machine's core.autocrlf setting.
+**/files/** text eol=lf

.github/workflows/hadolint.yml

@@ -0,0 +1,22 @@
+---
+name: hadolint
+
+"on":
+  pull_request:
+    branches:
+      - develop
+
+jobs:
+  hadolint:
+    name: hadolint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+      - name: Run hadolint (R images)
+        uses: hadolint/hadolint-action@v3.3.0
+        with:
+          dockerfile: images/labkey/*/Dockerfile
+          recursive: true
+          failure-threshold: 'warning'
+          ignore: 'DL3008'  # Don't worry about pinning versions

.github/workflows/shellcheck.yml

@@ -0,0 +1,16 @@
+---
+name: 'Run Shellcheck'
+
+"on":
+  - pull_request
+
+jobs:
+  shellcheck:
+    name: Shellcheck
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+
+      - name: Run ShellCheck
+        uses: ludeeus/action-shellcheck@2.0.0

.github/workflows/validate_pr.yml

@@ -0,0 +1,26 @@
+---
+# Workflow to validate Pull Request branches
+name: PR Validation
+
+# Trigger on PR creation
+"on":
+  pull_request:
+    types:
+      - opened
+      - reopened
+      - ready_for_review
+
+jobs:
+  validate_pr:
+    if: github.event.pull_request.head.repo.owner.login == 'LabKey'
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Validate PR Branches
+        uses: LabKey/gitHubActions/validate-pr@develop
+        with:
+          pr_base: ${{ github.event.pull_request.base.ref }}
+          pr_head: ${{ github.event.pull_request.head.ref }}
+          pr_number: ${{ github.event.pull_request.number }}
+          pr_title: ${{ github.event.pull_request.title }}
+          github_token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/yamllint.yml

@@ -0,0 +1,16 @@
+---
+name: 'Yamllint GitHub Actions'
+
+"on":
+  - pull_request
+
+jobs:
+  yamllint:
+    name: 'Yamllint'
+    runs-on: ubuntu-latest
+    steps:
+      - name: 'Checkout'
+        uses: actions/checkout@v6
+
+      - name: yaml-lint
+        uses: ibiqlik/action-yamllint@v3

.gitignore

@@ -0,0 +1 @@
+.claude/

images/labkey/Makefile

@@ -0,0 +1,31 @@
+# Build the LabKey R Docker images.
+#
+# Usage:
+#   make <target> [R_VERSION=<tag>]
+#
+# Targets:
+#   r             labkey/r            (from ubuntu; version is fixed in the Dockerfile)
+#   rsandbox      labkey/rsandbox     (from rocker/r-ver:$(R_VERSION))
+#   rstudio-base  labkey/rstudio-base (from rocker/rstudio:$(R_VERSION))
+#   rstudio       labkey/rstudio      (from labkey/rstudio-base:$(R_VERSION); builds rstudio-base first)
+#   all           build every image above
+#
+# Requires Docker 17.05.0 or greater.
+
+.PHONY: all r rsandbox rstudio-base rstudio
+
+R_VERSION ?= latest
+
+all: r rsandbox rstudio-base rstudio
+
+r:
+	docker build -t labkey/r:latest r
+
+rsandbox:
+	docker build --build-arg VERSION=$(R_VERSION) -t labkey/rsandbox:$(R_VERSION) rsandbox
+
+rstudio-base:
+	docker build --build-arg VERSION=$(R_VERSION) -t labkey/rstudio-base:$(R_VERSION) rstudio-base
+
+rstudio: rstudio-base
+	docker build --build-arg VERSION=$(R_VERSION) -t labkey/rstudio:$(R_VERSION) rstudio

images/labkey/r/Dockerfile

@@ -1,13 +1,10 @@
-ARG VERSION=18.04
+ARG VERSION=24.04
 FROM ubuntu:${VERSION}
 
 RUN apt-get update && \
-    apt-get install -y --no-install-recommends apt-transport-https apt-utils software-properties-common
-
-RUN apt-get install -y --no-install-recommends build-essential dos2unix libopenblas-dev libssl-dev libxml2-dev nano pandoc procps xvfb x11-common
-
-# NOTE much faster to use apt to install prebuilt packages than using "install.packages()"
-RUN DEBIAN_FRONTEND=noninteractive apt-get install -y \ 
+    apt-get install -y --no-install-recommends apt-transport-https apt-utils software-properties-common && \
+    apt-get install -y --no-install-recommends build-essential libopenblas-dev libssl-dev libxml2-dev nano pandoc procps xvfb x11-common && \
+    DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
     r-base \
     r-cran-bitops \
     r-cran-cairo \
@@ -28,12 +25,14 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get install -y \
     r-cran-markdown \
     r-cran-scales \
     r-cran-stringr \
-    r-cran-tidyr 
+    r-cran-tidyr && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/*
 
-COPY install.R /tmp/
-RUN R --vanilla -f /tmp/install.R 
+COPY files/install.R /tmp/
+RUN R --vanilla -f /tmp/install.R
 
-RUN ln -fs /usr/share/zoneinfo/America/Los_Angeles/etc/localtime && \
+RUN ln -fs /usr/share/zoneinfo/America/Los_Angeles /etc/localtime && \
     dpkg-reconfigure --frontend noninteractive tzdata
 
 RUN R --version

images/labkey/rsandbox/Dockerfile

@@ -1,9 +1,9 @@
-ARG VERSION=3.6.3
+ARG VERSION=latest
 FROM rocker/r-ver:${VERSION}
 
 RUN apt-get update && \
 	apt-get install -y --no-install-recommends apt-transport-https apt-utils software-properties-common && \
-	apt-get install -y --no-install-recommends build-essential dos2unix libopenblas-dev libxml2-dev nano pandoc procps xvfb x11-common && \
+	apt-get install -y --no-install-recommends build-essential libopenblas-dev libxml2-dev nano pandoc procps xvfb x11-common libuv1-dev && \
 	apt-get install -y --no-install-recommends sudo && \
 	apt-get install -y --no-install-recommends  \
 		curl libcurl4-openssl-dev \
@@ -28,9 +28,8 @@ RUN useradd docker || true \
 	&& chmod -R 775 /home/docker || true
 
 
-COPY install.R /
-RUN dos2unix install.R && \
-    R --no-site-file -f install.R &&  \
+COPY files/install.R /
+RUN R --no-site-file -f install.R &&  \
     chmod -R 755 /usr/local/lib/R/site-library
 
 CMD ["su", "docker", "-c", "/bin/bash"]

images/labkey/rsandbox/README.md

@@ -3,11 +3,11 @@ labkey/rsandbox:latest
 
 Dockerfile for building Dockerized LabKey R image using with the latest R release version. 
 
-Run `./make` to generate R image `labkey/rsandbox:latest`. 
+Run `make rsandbox` from `images/labkey/` to generate R image `labkey/rsandbox:latest`.
 
-Note that actual R version might differ based on latest R version at the time the image is built. 
+Note that actual R version might differ based on latest R version at the time the image is built.
 
-To tag the image with the actual R version at the time of build, change `latest` in `make` file to the latest R version, for example: `3.5.1`.
+To tag the image with the actual R version at the time of build, pass `R_VERSION`, for example: `make rsandbox R_VERSION=4.6.1`.
 
 For more information, see:
 

images/labkey/rstudio-base/Dockerfile

@@ -1,26 +1,25 @@
-ARG VERSION=4.0.5
+ARG VERSION=latest
 FROM rocker/rstudio:${VERSION}
 
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
 RUN apt-get update && \
     apt-get install -y --no-install-recommends apt-utils && \
-    apt-get install -y --no-install-recommends dos2unix nano procps libxml2-dev xvfb zlib1g-dev && \
+    apt-get install -y --no-install-recommends nano procps libxml2-dev xvfb zlib1g-dev && \
     apt-get clean && \
     rm -rf /var/lib/apt/lists/*
 
-COPY conf /etc/cont-init.d/
-RUN dos2unix /etc/cont-init.d/conf
+COPY files/conf /etc/cont-init.d/
 
-COPY install.R /
+COPY files/install.R /
 RUN R --no-site-file -f install.R &&  \
     chmod -R 755 /usr/local/lib/R/library && \
     chmod -R 755 /usr/local/lib/R/site-library
 
-COPY Rprofile.site /Rprofile.site.tmp
-RUN dos2unix /Rprofile.site.tmp && \
-    cat /Rprofile.site.tmp >> /usr/local/lib/R/etc/Rprofile.site && \
+COPY files/Rprofile.site /Rprofile.site.tmp
+RUN cat /Rprofile.site.tmp >> /usr/local/lib/R/etc/Rprofile.site && \
     rm /Rprofile.site.tmp
 RUN echo "R_LIBS_USER=~/R/$(R --version | grep -Eo '[0-9]+[.]+[0-9]+')/library" >> /usr/local/lib/R/etc/Renviron
 
-COPY cleanupSessionFiles.sh /
-RUN dos2unix /cleanupSessionFiles.sh
+COPY files/cleanupSessionFiles.sh /
 RUN chmod 755 /cleanupSessionFiles.sh