Job Source Actions - #2046
Merged
Merged
Conversation
XingY
approved these changes
Aug 5, 2026
| const sampleType = caseInsensitive(row, 'SampleSet')?.displayValue; | ||
| const entityType = | ||
| entitySchema === SCHEMAS.SAMPLE_SETS.SCHEMA | ||
| ? caseInsensitive(row, 'SampleSet')?.displayValue |
Contributor
There was a problem hiding this comment.
nit: move the SCHEMAS.SAMPLE_SETS.SCHEMA? condition inside caseInsensitive call
Contributor
Author
There was a problem hiding this comment.
Readability is in the eye of the beholder. I think I'll leave it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We recently added the ability for our LIMS users to add sources to jobs. We are now adding actions that can be performed using these sources.
Related Pull Requests
Changes
resolveSampleParentTypestoresolveEntityParentTypesto support resolution of multiple parent types for sources and samplespopoverPlacementproperty toSelectionMenuItem