GitHub Issue 1366: inventory-addSamples API cleanup - #7916
Merged
Conversation
cnathe
approved these changes
Aug 11, 2026
| filter.addClause(cf.createFilterClause(entityTable.getSchema(), FieldKey.fromParts("Container"))); | ||
|
|
||
| Set<Long> inScope = new HashSet<>(new TableSelector(entityTable, Collections.singleton("RowId"), filter, null).getArrayList(Long.class)); | ||
| return entityIds.stream().anyMatch(id -> !inScope.contains(id)); |
Contributor
There was a problem hiding this comment.
since we are dealing with RowIds in both the entityIds collection and the inScope collection, could we just return a check for if the size of the collections match? If the size of the inScope set is smaller than the entityIds side, then there are some not in scope, right?
Contributor
There was a problem hiding this comment.
I see now after doing the CR on the limsModules side that this method was just ported over from WorkflowManager, so fine to leave it as is. I thought this was new code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes