fix: keep unprefixed v* tags for the LoopStructural release-please component - #314
Merged
Merged
Conversation
…mponent Repointing the LoopStructural component's path to "." (in #312) let release-please discover its component name from pyproject.toml, which flipped it to the manifest-mode default of prefixing tags with the component name (LoopStructural-v*). No such tags exist -- every past release used a plain v* tag -- so release-please couldn't find the real last release and fell back to an ancient v1.6.5 tag as its baseline, computing a regressive "next version" of 1.6.5 in PR #313. include-component-in-tag: false restores the historical plain v* tag scheme so release-please finds v1.7.1 as the last release again. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
lachlangrose
added a commit
that referenced
this pull request
Aug 14, 2026
#314 deleted this file, but the release-please run triggered by that same merge re-created it with __version__ = "1.7.2" (LoopStructural's version, not loop_interpolation's real "0.0.1") before PR #313 was merged. Its own filename-search log line still showed the file as found on that run -- most likely GitHub's code-search index hadn't caught up with the deletion commit yet. Root cause: pointing the LoopStructural component's path at "." makes release-please's "find any file named version.py" search genuinely repo-wide rather than scoped to LoopStructural/, so it can collide with any version.py anywhere in the tree, present or future (e.g. the still-unmerged map2loop/loopstructural_visualisation packages each have their own). There's no release-please config to scope that search to a subpath, so the durable fix is having no other version.py files left for it to find. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoopStructuralcomponent's path to.let release-please derive its component name frompyproject.toml, which switched tag generation to the manifest-mode default of prefixing tags with the component name (LoopStructural-v*).v*tag (v1.7.1,v1.7.0, ...). Confirmed directly from the release-please run log that produced PR chore: release master #313:⚠ Found release tag with component '', but not configured in manifest— one per existing unprefixed tag, each rejected because it doesn't match the newly-expectedLoopStructural-v*scheme. With no matching tag, release-please fell back to walking all 415 commits in the repo's history, producing PR chore: release master #313's regressive.: "1.6.5"manifest bump and the giant stale changelog dump.include-component-in-tag: falserestores the historical unprefixed tag scheme, so release-please findsv1.7.1as the last release again.packages/loop_interpolation/src/loop_interpolation/loopsolver/version.py, a stray unused file (not imported anywhere;loop_interpolationalready has a static version in its ownpyproject.toml). It's collateral damage from the same path change: release-please's generic "find any file namedversion.py" search used to be scoped to the oldLoopStructural/subdirectory, and now scans the whole repo, which is why this unrelated file showed up in PR chore: release master #313's diff too.Test plan
git tag -lthat all past LoopStructural releases used plainv*tags (v1.6.5...v1.7.1), while the workspace sub-packages use prefixed tags (loop-common-v0.0.2).v1.7.1wasn't found and where the 415-commit fallback came from.loopsolver/version.pyhas no importers anywhere in the repo.1.6.5downgrade, and no longer touchesloopsolver/version.py.🤖 Generated with Claude Code