Switch Frontier CI from the revoked hackathon QOS to normal - #1746
Open
sbryngelson wants to merge 1 commit into
Open
Switch Frontier CI from the revoked hackathon QOS to normal#1746sbryngelson wants to merge 1 commit into
sbryngelson wants to merge 1 commit into
Conversation
The hackathon QOS grant on CFD154 ended, and every Frontier CI job now fails at submission with "Batch job submission failed: Invalid qos specification" (all 12 Frontier jobs in run 32414716605). retry-sbatch correctly classifies this as non-transient, so the failure is immediate. normal is the only QOS remaining on this allocation that permits more than one job at a time -- debug caps at MaxSubmitPU=1, develop and jupyter at MaxJobsPU=1 -- so it is the only one that can run the CI matrix concurrently. Partition, node/task counts, walltimes, and --stepmgr are unchanged. Turnaround does regress: 1-node queue waits over the preceding three days ran a 0.53 min median under hackathon versus 5.1 min median and 5.2 h p90 under normal. Restoring a priority QOS for CI is the real fix; this unblocks the pipeline in the meantime.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Frontier CI SLURM submission defaults to use a valid QOS now that the temporary hackathon QOS grant for allocation CFD154 has ended, unblocking Frontier-based GitHub Actions runs.
Changes:
- Switches Frontier (
frontier) default QOS fromhackathontonormal, with an inline rationale comment. - Switches Frontier AMD (
frontier_amd) default QOS fromhackathontonormal.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1746 +/- ##
=======================================
Coverage 61.61% 61.61%
=======================================
Files 84 84
Lines 21520 21520
Branches 3180 3180
=======================================
Hits 13259 13259
Misses 6082 6082
Partials 2179 2179 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Frontier CI is currently failing on every job. The
hackathonQOS that.github/scripts/submit-slurm-job.shsubmits under was a temporary grant onCFD154, and that grant has ended —sbatchnow rejects it outright:All 12 Frontier jobs (CCE and AMD, cpu and gpu, including the Case Opt jobs) failed this way in run 32414716605.
retry-sbatchcorrectly classifies this as non-transient, so it fails immediately rather than burning retries.The
hackathonQOS was introduced for Frontier CI in c99ac2d ("Default Frontier templates to hackathon QOS/partition", #1407).This switches both the
frontierandfrontier_amdblocks toqos="normal". Nothing else changes — partition (batch),-n 8/-n 32,01:59:00walltimes, and--stepmgrare all untouched, as is Phoenix'sembers.Why
normalspecificallyIt's the only QOS left on this allocation that permits more than one job at a time, which the CI matrix requires:
normaldebugMaxSubmitPU=1— one job in the queue, perioddevelopMaxJobsPU=1, plusnode=30and a hard 2hMaxWalljupyterMaxJobsPU=1developwas the pre-#1407 setting, but withMaxJobsPU=1it would serialize the matrix one job at a time, and its 2hMaxWallleaves no headroom over our01:59:00.Known regression
Turnaround gets worse. Measured 1-node queue waits on Frontier over the three days before the grant lapsed:
hackathonnormalhackathongave CI a tight sub-2-minute start.normalhas a 5-minute median but a long tail, and each run waits on the slowest of ~12 jobs. This unblocks the pipeline; restoring a priority QOS for CI is the real fix and needs an OLCF request againstCFD154.Type of change
Testing
Validated the exact job shapes this script generates against the live Frontier scheduler with
sbatch --test-only:Both are rejected with
Invalid qos specificationunder-q hackathon, confirming the diagnosis and the fix. Also submitted real 1-node jobs under-q normalto confirm concurrency: four submitted simultaneously all went PENDING → RUNNING in 23 s on four separate nodes, with no per-user limit rejections.Full CI on this PR is the real check.
Checklist
CI-only configuration change; no test or documentation surface.