Skip to content

Revise pull request template for contribution guidelines - #1752

Merged
sbryngelson merged 1 commit into
masterfrom
sbryngelson-patch-2
Aug 23, 2026
Merged

Revise pull request template for contribution guidelines#1752
sbryngelson merged 1 commit into
masterfrom
sbryngelson-patch-2

Conversation

@sbryngelson

Copy link
Copy Markdown
Member

Updated the pull request template to emphasize contribution policy and expectations for submissions.

Description

Summarize your changes and the motivation behind them.

Closes #(issue number).

Type of change (delete unused ones)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe)

Testing

How did you test your changes?

Checklist

Check these like this [x] to indicate which of the below applies.

  • I added or updated tests for new behavior
  • I updated documentation if user-facing behavior changed

See the developer guide for full coding standards.

GPU changes (expand if you modified src/simulation/)
  • GPU results match CPU results
  • Tested on NVIDIA GPU or AMD GPU

AI code reviews

Reviews are not retriggered automatically. To request a review, comment on the PR:

  • @claude full review — Claude full review (also triggers on PR open/reopen/ready)
  • Or add label claude-full-review — Claude full review via label

Updated the pull request template to emphasize contribution policy and expectations for submissions.
Copilot AI lite review requested due to automatic review settings August 23, 2026 18:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s GitHub pull request template to emphasize contribution expectations, particularly around demonstrating understanding and real-world context, and adds an explicit acknowledgement checkbox.

Changes:

  • Replaces the prior PR template sections (description/testing/checklists) with a “Contribution Policy” section.
  • Adds an “Acknowledgement” checkbox affirming the contribution policy.
  • Removes prior prompts for issue linking, testing details, GPU checklist, and AI review retrigger instructions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +1 to +11
## Contribution Policy

Summarize your changes and the motivation behind them.
We do not accept pull requests generated primarily by AI without genuine understanding or real-world usage context.

Closes #(issue number).
All contributions are expected to demonstrate:
- A clear understanding of the codebase
- Alignment with product direction
- Thoughtful reasoning behind changes
- Evidence of real-world usage or hands-on experience with the problem

### Type of change (delete unused ones)
If these expectations are not met, we would prefer to implement the changes ourselves rather than spend time reviewing low-effort submissions.
@sbryngelson
sbryngelson merged commit dad3db9 into master Aug 23, 2026
35 checks passed
@sbryngelson
sbryngelson deleted the sbryngelson-patch-2 branch August 23, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants