Skip to content

[Fix|Local] Desktop release dry run - #1775

Merged
CREDO23 merged 2 commits into
devfrom
fix/release-dryrun
Sep 14, 2026
Merged

CREDO23 merged 2 commits into
devfrom
fix/release-dryrun

Conversation

@CREDO23

@CREDO23 CREDO23 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Type the onboarding fetchMock as fetch so the frontend tsc -b build passes
  • Drop the Intel Mac build: torch (2.3+) and onnxruntime (1.24+) no longer publish Intel Mac wheels, and macOS 26 is Apple's last Intel release

Test plan

  • Frontend tsc -b and vitest pass
  • Desktop Release dry run goes green on Apple Silicon, Windows, Linux

High-level PR Summary

This PR fixes the desktop release dry run by addressing two issues: adding proper TypeScript typing to the fetchMock in the onboarding test file so that tsc -b passes, and removing the Intel Mac build configuration from the release workflow since torch 2.3+ and onnxruntime 1.24+ no longer provide Intel Mac wheels and macOS 26 is Apple's last Intel release.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 surfsense_local/frontend/src/features/onboarding/onboarding-page.test.tsx
2 .github/workflows/release-local.yml

Need help? Join our Discord

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
surf-sense-frontend Ready Ready Preview Sep 14, 2026 2:00pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 9e21897b-69bd-4bae-bff6-31e635355e78

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CREDO23
CREDO23 merged commit 4b50bb5 into dev Sep 14, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant