[Fix|Local] Desktop release dry run - #1775
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
fetchMockasfetchso the frontendtsc -bbuild passesTest plan
tsc -bandvitestpassHigh-level PR Summary
This PR fixes the desktop release dry run by addressing two issues: adding proper TypeScript typing to the
fetchMockin the onboarding test file so thattsc -bpasses, and removing the Intel Mac build configuration from the release workflow since torch 2.3+ and onnxruntime 1.24+ no longer provide Intel Mac wheels and macOS 26 is Apple's last Intel release.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_local/frontend/src/features/onboarding/onboarding-page.test.tsx.github/workflows/release-local.yml