Skip to content

refactor(local): move the update prompt from a banner to a title bar button - #1778

Merged
AnishSarkar22 merged 2 commits into
MODSetter:devfrom
AnishSarkar22:fix/local-app-ui
Sep 14, 2026
Merged

AnishSarkar22 merged 2 commits into
MODSetter:devfrom
AnishSarkar22:fix/local-app-ui

Conversation

@AnishSarkar22

@AnishSarkar22 AnishSarkar22 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Description

Motivation and Context

FIX #

Screenshots

API Changes

  • This PR includes API changes

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactoring
  • Documentation
  • Dependency/Build system
  • Breaking change
  • Other (specify):

Testing Performed

  • Tested locally
  • Manual/QA verification

Checklist

  • Follows project coding standards and conventions
  • Documentation updated as needed
  • Dependencies updated as needed
  • No lint/build errors or new warnings
  • All relevant tests are passing

High-level PR Summary

This PR refactors the update notification UI from a full-width banner into a compact icon button in the title bar. The changes introduce a new --notice color variable to the design system for non-destructive attention-grabbing elements, replace the UpdateBanner component with an UpdateButton that appears in the dashboard's title bar controls, and update corresponding tests to reflect the new behavior. The update notification is now displayed as a ghost button with a download icon that only appears when an update is ready to install.

⏱️ Estimated Review Time: 15-30 minutes

💡 Review Order Suggestion
Order File Path
1 .cursor/skills/color-system/PALETTE.css
2 surfsense_local/frontend/src/index.css
3 surfsense_local/frontend/src/components/ui/icons.tsx
4 surfsense_local/frontend/src/features/updates/update-settings.tsx
5 surfsense_local/frontend/src/features/dashboard/dashboard-page.tsx
6 surfsense_local/frontend/src/app/app-bootstrap.tsx
7 surfsense_local/frontend/src/features/updates/update-settings.test.tsx
8 surfsense_local/frontend/src/test-utils.tsx

Need help? Join our Discord

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

@AnishSarkar22 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2c2c54bb-801b-4616-961b-5b140ff794ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AnishSarkar22 AnishSarkar22 changed the title Fix/local app UI refactor(local): move the update prompt from a banner to a title bar button Sep 14, 2026
@AnishSarkar22
AnishSarkar22 merged commit a84874e into MODSetter:dev Sep 14, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant