feat(keygen): pin Keygen CE web and worker images for Coolify - #1784
Merged
Merged
Conversation
Coolify has no field for a container command, so the worker needs a Dockerfile to set CMD. The web file keeps both processes pinned to the same tag in one place.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request adds Dockerfiles for Keygen web and worker containers. Both use ChangesKeygen containers
Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the two Dockerfiles Coolify deploys the self-hosted Keygen CE instance from.
webneeds no command override — the base image already setsCMD ["web"]— but it is kept as a file so both processes stay pinned to the same tag in one reviewable place.workerexists because Coolify's Docker Image resource has no field for a container command; it only exposes--entrypointvia Custom Docker Options. A two-line Dockerfile settingCMD ["worker"]is the smallest way to run Sidekiq from the same image.Pinned to
keygen/api:v1.7.2rather thanlatest, so a redeploy cannot pull a new version and run its migrations against live license data. Upgrades bump both files together.No behaviour change to anything currently deployed — these files are only read by the two new Coolify resources.
High-level PR Summary
This PR adds two minimal Dockerfiles to pin the Keygen CE deployment to version
v1.7.2for Coolify. ThewebDockerfile adds health check configuration and explicit port exposure, while theworkerDockerfile overrides the command to run Sidekiq. Both files ensure the deployment uses a specific tagged version rather thanlatest, preventing unintended upgrades that could affect live license data.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
docker/keygen/web/Dockerfiledocker/keygen/worker/DockerfileSummary by CodeRabbit