Add ISMIP7 fracture test case for shelf-collapse pathways - #975
Open
trhille wants to merge 7 commits into
Open
Conversation
Add a 'fracture' test case to the ismip7_forcing test group that processes the ISMIP7 surface-melt-driven ice shelf collapse forcing (AIS) via three pathways, each as its own step: - process_excess_melt (Path A): remaps the excess meltwater field. Reconstructs x/y coordinates and corrects the y-axis orientation of the source file before conservative remapping. - process_lake_properties (Path B): remaps supraglacial lake mean depth and area fraction (Grau et al. 2025) via bilinear remapping. - process_shelf_collapse (Path C): remaps the annual ice shelf collapse mask via neareststod, rounding to 0/1. Add per-pathway remap-method config options and documentation.
Each fracture step returns early without processing its file when its [ismip7_fracture] remapping-method option is set to None. This lets a user process only the pathways whose source files are available, without adding separate enable/disable flags.
Capture the integer years from the time coordinate before renaming the time dimension to Time, since the rename also renames the coordinate variable. Drop the leftover Time coordinate from the output.
Convert the excess melt field from mm w.e. yr-1 to kg m-2 s-1 using 1 mm w.e. = 1 kg m-2 and a 365-day year, consistent with other MALI mass fluxes.
Collaborator
Author
TestingProcessing these files took less than one minute on one Perlmutter node. shelf_collapse_mask.movCESM2-WACCM ssp5-8.5 lake depth and area: lakes.movCESM2-WACCM ssp5-8.5 excess surface melt: excess_melt.mov |
Move the duplicated extrapolation and rename/xtime boilerplate from the three fracture steps into a shared remap_utils module (extrapolate_source, open_rename_and_trim, add_xtime_and_write). The step-specific logic (unit conversion, mask rounding, per-variable attrs) stays in each step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a 'fracture' test case to the ismip7_forcing test group that processes the ISMIP7 surface-melt-driven ice shelf collapse forcing (AIS) via three pathways, each as its own step:
Add per-pathway remap-method config options and documentation.
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes