Conversation
A `repos/<client>.md` overlay is the client-specific half of a skill, so the client's platform team owns it by default: `metamask-extension` to extension-platform, `metamask-mobile` to mobile-platform, `core` to core-platform. Domains with their own team keep their overlays through a per-domain override. The defaults sit after the domain block because the last matching pattern wins. Placed first, every domain rule below would override them and they would never apply. Of 52 overlay files on `main`, 24 change owner, all inside `coding`, `performance` and `pr-workflow`, where each moves from both platform teams to its own client's team. None move away from a domain-owned team.
MajorLift
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A repo overlay,
repos/<client>.md, is the client-specific half of a skill. Today its owner is whatever its domain line says, so in the domains both platform teams co-own, an extension-only file is owned by both teams, and incodingby@MetaMask/core-platformas well. The team responsible for the client does not own the text written about it.Overview
Adds a default owner for overlays, one per client:
metamask-extensionto@MetaMask/extension-platform,metamask-mobileto@MetaMask/mobile-platform,coreto@MetaMask/core-platform.The defaults sit after the domain block rather than at the top. The last matching pattern wins, so placed first they would be overridden by every domain rule and never apply.
Domains with their own team keep their overlays through a per-domain override:
assets,perps,swaps,testingandui. Removing one of those lines is the lever if a platform team should own that domain's overlays too.This does not depend on the open domain PRs. #44 (platform), #69 (typescript), #76 (observability), #81 (stability) and #83 (security) each carry per-domain overlay rules that this makes redundant. They are harmless, and can be removed once both land.
Showcase
Ownership of every overlay file on
main, before and after: 52 files, 24 change owner, all withincoding,performanceandpr-workflow. Each moves from both platform teams to its own client's team. None move away from a domain-owned team. Theperpsoverlay stays with@MetaMask/perps, which also confirms the override matches, since without it that file would land on extension-platform.Three
codingoverlays lose@MetaMask/core-platformas a reviewer. That is the design working, and it is a real removal of a reviewer.The before-and-after ownership comes from a pattern matcher written for this change, not from GitHub. GitHub's own checker covers whether the patterns parse:
GET /repos/MetaMask/skills/codeowners/errorsreports 38 errors on this branch against 30 onmain, allUnknown owner, which is team visibility to the querying token. The difference of 8 is exactly the owner references added. No error of any other kind appears.