Refresh the committed functions snapshot against the MEOS surface - #19
Merged
estebanzimanyi merged 1 commit intoSep 3, 2026
Conversation
WITNESS: `go build ./functions` against a libmeos built from MobilityDB
40eb373334 at -DALL=ON reports
functions/meos_meos_internal_geo.go:115:2: could not determine kind of
name for C.geo_set_srid_int
MEOS publishes `geo_set_srid`, and `geo_set_srid_int` appears in neither the
installed headers nor the exported symbols of libmeos.so, so the snapshot
names a spelling the library does not carry.
MEASURED: regenerating with `python3 tools/codegen.py` against a catalog
derived from that same commit moves five files, +900 -35, and `go build
./functions` then exits 0. The retired name drops to 0 occurrences while
`geo_set_srid` remains the one spelling present.
WHY: `functions/` is the snapshot a `go get` consumer compiles, so a name MEOS
has retired reaches consumers as a build failure in their own tree. The
snapshot is a projection of the catalog and carries no independent authority;
where the two disagree the catalog is right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WITNESS:
go build ./functionsagainst a libmeos built from MobilityDB40eb373334 at -DALL=ON reports
MEOS publishes
geo_set_srid, andgeo_set_srid_intappears in neither theinstalled headers nor the exported symbols of libmeos.so, so the snapshot
names a spelling the library does not carry.
MEASURED: regenerating with
python3 tools/codegen.pyagainst a catalogderived from that same commit moves five files, +900 -35, and
go build ./functionsthen exits 0. The retired name drops to 0 occurrences whilegeo_set_sridremains the one spelling present.WHY:
functions/is the snapshot ago getconsumer compiles, so a name MEOShas retired reaches consumers as a build failure in their own tree. The
snapshot is a projection of the catalog and carries no independent authority;
where the two disagree the catalog is right.