Skip to content

Drop from a member name the prefix that classified it - #125

Merged
estebanzimanyi merged 1 commit into
MobilityDB:masterfrom
estebanzimanyi:fix/ooname-strips-matched-prefix
Sep 3, 2026
Merged

Drop from a member name the prefix that classified it#125
estebanzimanyi merged 1 commit into
MobilityDB:masterfrom
estebanzimanyi:fix/ooname-strips-matched-prefix

Conversation

@estebanzimanyi

Copy link
Copy Markdown
Member

A method's ooName is its function name with the class's token dropped, and the
token tried is the class's own lower-cased name. A class whose C prefix is
something else keeps that prefix in every member: Geometry is reached by
geom_*, Geography by geog_* and GeomSet by geoset_*, so their members
read geomBuffer, geogFromHexewkb, geosetStartValue — the class named
twice, once by the receiver and once inside the call.

The classifier already knows which prefix matched, since that is how it chose
the class, so the name drops that prefix too, longest match first. 55 members
across those three classes lose it and no class ends up holding two methods of
one name. One token goes, not every repetition of it: set_set_subspan keeps
its setSubspan, the inner set being part of what the member says.

Stacks on #124.

@estebanzimanyi
estebanzimanyi force-pushed the fix/ooname-strips-matched-prefix branch 2 times, most recently from 901cf02 to 7360ede Compare September 3, 2026 00:17
A method's `ooName` is its function name with the class's token dropped, and the
token tried is the class's own lower-cased name. A class whose C prefix is
something else keeps that prefix in every member: `Geometry` is reached by
`geom_*`, `Geography` by `geog_*` and `GeomSet` by `geoset_*`, so their members
read `geomBuffer`, `geogFromHexewkb`, `geosetStartValue` — the class named
twice, once by the receiver and once inside the call.

The classifier already knows which prefix matched, since that is how it chose
the class, so the name drops that prefix too, longest match first. 55 members
across those three classes lose it and no class ends up holding two methods of
one name. One token goes, not every repetition of it: `set_set_subspan` keeps
its `setSubspan`, the inner `set` being part of what the member says.
@estebanzimanyi
estebanzimanyi force-pushed the fix/ooname-strips-matched-prefix branch from 7360ede to d2c27ec Compare September 3, 2026 00:23
@estebanzimanyi
estebanzimanyi merged commit 4d6dfe1 into MobilityDB:master Sep 3, 2026
3 checks passed
@estebanzimanyi
estebanzimanyi deleted the fix/ooname-strips-matched-prefix branch September 3, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant