Read from the catalog which arguments are arrays - #31
Merged
estebanzimanyi merged 1 commit intoSep 3, 2026
Merged
Conversation
An array argument is one parameter to the caller and two to MEOS, the pointer and its length, and the layer told them apart by the length's NAME. The surface spells that length eight ways — `count`, `count1`, `count2`, `size`, `ngeoms`, `keys_len`, `path_len`, `pixels_size` — so the rule reached the two it knew and left the rest, and it had to exclude the receiver by hand because `set_value_n` looks the same as an array beside its length. `shape.inputArrays` names each array, the parameter its length comes from and its element type, so the layer reads it and both problems go: a length is found whatever it is called, and a receiver is no array because the catalog does not say it is one. 14 methods more — `Jsonb.ExistsArray`, `Jsonb.DeleteArray`, `Geo.ClusterKmeans`, `Geo.ClusterWithin` and their kin, whose lengths are `keys_len` and `ngeoms` — 1246 methods against 1232, 49 deferred against 63. Two tests take an array each: a geometry set built from an array of geometries, and a jsonb asked which of an array of keys it holds, whose length MEOS calls `keys_len`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An array argument is one parameter to the caller and two to MEOS, the pointer
and its length, and the layer told them apart by the length's NAME. The surface
spells that length eight ways —
count,count1,count2,size,ngeoms,keys_len,path_len,pixels_size— so the rule reached the two it knew andleft the rest, and it had to exclude the receiver by hand because
set_value_nlooks the same as an array beside its length.
shape.inputArraysnames each array, the parameter its length comes from andits element type, so the layer reads it and both problems go: a length is found
whatever it is called, and a receiver is no array because the catalog does not
say it is one. 14 methods more —
Jsonb.ExistsArray,Jsonb.DeleteArray,Geo.ClusterKmeans,Geo.ClusterWithinand their kin, whose lengths arekeys_lenandngeoms— 1246 methods against 1232, 49 deferred against 63.Two tests take an array each: a geometry set built from an array of geometries,
and a jsonb asked which of an array of keys it holds, whose length MEOS calls
keys_len.