Read the ecosystem's own definition of the two test-outcome rules - #66
Merged
Conversation
The conformance job reaches the rules through MobilityDB/MEOS-API/.github/actions/check-test-outcome, the composite action JMEOS, MobilityFlink, MobilitySpark and MobilityKafka already use, rather than stating them again in shell. The rules live once, beside the catalog, and a copy of a rule about coverage is exactly the thing that drifts. The same script answers over a local log, so a by-hand answer and the CI answer cannot differ. The floor becomes 141, which is every result line `go test -v` writes: 77 top-level tests and 64 subtests. The shared rules count subtests, and they belong in the total, since a t.Run whose body skips is as unrun as its parent would be and deleting a case from a table-driven test moves nothing else. The same suite reads 141 against this floor with no database, where 28 of those lines are skips the rules refuse, and 141 with none skipped where the job supplies the database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conformance job reaches the rules through
MobilityDB/MEOS-API/.github/actions/check-test-outcome, the composite action
JMEOS, MobilityFlink, MobilitySpark and MobilityKafka already use, rather than
stating them again in shell. The rules live once, beside the catalog, and a
copy of a rule about coverage is exactly the thing that drifts. The same script
answers over a local log, so a by-hand answer and the CI answer cannot differ.
The floor becomes 141, which is every result line
go test -vwrites: 77top-level tests and 64 subtests. The shared rules count subtests, and they
belong in the total, since a t.Run whose body skips is as unrun as its parent
would be and deleting a case from a table-driven test moves nothing else. The
same suite reads 141 against this floor with no database, where 28 of those
lines are skips the rules refuse, and 141 with none skipped where the job
supplies the database.