Build every family, as the rest of the ecosystem does - #70
Merged
Conversation
Both configures in the conformance job take -DALL=ON: the PostgreSQL extension the SQL routes run over, and the standalone libmeos the streaming engine links. ALL means all. A family left out is stripped at preprocess time, so a job without it reports on a smaller MobilityDB than the one it names, and -DALL=ON covers a family added later where a list of names written here would not. This tier generates its temporal type table from a catalog that covers every family, so a database or a library narrower than that catalog cannot answer for the types the tier declares it knows: the table names 23 temporal types, among them tcbuffer, tpose, trgeometry and ts2cell. The dependencies are MobilityDB's own, from its pgversion.yml. libh3 is the H3 family's library, located on disk and pinned through -DH3_INCLUDE_DIR and -DH3_LIBRARY because the pgdg package layout differs between releases. The vendored pgPointCloud that POINTCLOUD compiles needs the autotools with libxml2 and zlib. The h3 and pointcloud PostgreSQL extensions are a separate need from their libraries: MobilityDB's control file requires them when their family is on, so CREATE EXTENSION pulls them in and they must exist in the cluster, and apt.postgresql.org carries both for the PostgreSQL this job runs. Measured against a libmeos built this way, whose meos.pc reads CBUFFER=1 H3=1 JSON=1 NPOINT=1 POINTCLOUD=1 POSE=1 QUADBIN=1 RASTER=1 RGEO=1 S2CELL=1, the tier builds, vets and runs its whole suite unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both configures in the conformance job take -DALL=ON: the PostgreSQL extension
the SQL routes run over, and the standalone libmeos the streaming engine links.
ALL means all. A family left out is stripped at preprocess time, so a job
without it reports on a smaller MobilityDB than the one it names, and -DALL=ON
covers a family added later where a list of names written here would not. This
tier generates its temporal type table from a catalog that covers every family,
so a database or a library narrower than that catalog cannot answer for the
types the tier declares it knows: the table names 23 temporal types, among them
tcbuffer, tpose, trgeometry and ts2cell.
The dependencies are MobilityDB's own, from its pgversion.yml. libh3 is the H3
family's library, located on disk and pinned through -DH3_INCLUDE_DIR and
-DH3_LIBRARY because the pgdg package layout differs between releases. The
vendored pgPointCloud that POINTCLOUD compiles needs the autotools with
libxml2 and zlib. The h3 and pointcloud PostgreSQL extensions are a separate
need from their libraries: MobilityDB's control file requires them when their
family is on, so CREATE EXTENSION pulls them in and they must exist in the
cluster, and apt.postgresql.org carries both for the PostgreSQL this job runs.
Measured against a libmeos built this way, whose meos.pc reads CBUFFER=1 H3=1
JSON=1 NPOINT=1 POINTCLOUD=1 POSE=1 QUADBIN=1 RASTER=1 RGEO=1 S2CELL=1, the
tier builds, vets and runs its whole suite unchanged.