fix(agent-core): use portable NO_PROXY for MCP children - #2866
Open
weivwang wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 96fa8ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
weivwang
marked this pull request as ready for review
August 12, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #1931
Problem
See linked issue. Kimi Code appends both bare and bracketed IPv6 loopback entries to
NO_PROXYbefore spawning stdio MCP servers. The bracketed form is required by Node's environment-proxy implementation, but Python httpx parses it as an invalid port and can terminate before the MCP handshake.What changed
NO_PROXYvalue without[::1]for non-Node MCP launchers while retaining the bare::1entry.[::1]so Node still bypasses proxies for IPv6 loopback.[::1]override for wrapper commands whose runtime cannot be inferred, and keep wildcard semantics unchanged.Validation:
pnpm --filter @moonshot-ai/agent-core test(4137 passed)pnpm --filter @moonshot-ai/agent-core-v2 test(4957 passed)pnpm --filter @moonshot-ai/agent-core typecheckpnpm --filter @moonshot-ai/agent-core-v2 typecheckpnpm exec oxlinton all changed TypeScript files[::1], while Undici needs[::1]to bypass an IPv6 loopback proxy.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.