fix(bash): honor cwd for backgrounded shell commands - #2900
Open
Fnine59 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 09967cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 155432823d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Fnine59
force-pushed
the
contrib/kimi-bash-cwd-2890
branch
from
August 13, 2026 19:07
1554328 to
d31244f
Compare
Fnine59
force-pushed
the
contrib/kimi-bash-cwd-2890
branch
from
August 14, 2026 02:30
d31244f to
09967cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #2890
Problem
The Bash tool prepends
cd <cwd> &&to the user's shell script. If the first user command is backgrounded with&, Bash backgrounds that entire AND-list, includingcd, so later lines silently run in the process's original directory.What changed
Pass
cwdthrough the process execution boundary in both engine implementations and leave thebash -cinput as the user's command. Bash also receives the requested path as its logicalPWD, preserving symlinked workspace paths; on Windows the process receives a native cwd while Git Bash receives the corresponding POSIX-stylePWD. Relativecwdvalues continue to resolve from the session working directory using the target platform's path rules.Added a regression test that backgrounds the first command and verifies the following line remains in the requested directory, a real symlink-workspace test with a stale inherited
PWD, and spawn-boundary assertions for both implementations.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.