Skip to content

Added pixi - #39

Open
Shekar V (vshekar) wants to merge 2 commits into
NSLS2:masterfrom
vshekar:add-pixi
Open

Added pixi#39
Shekar V (vshekar) wants to merge 2 commits into
NSLS2:masterfrom
vshekar:add-pixi

Conversation

@vshekar

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI lite review requested due to automatic review settings September 4, 2026 16:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Changes are limited to adding Pixi environment configuration and related git metadata, with only non-blocking maintainability suggestions.

Pull request overview

This PR introduces a Pixi-based (conda-forge) development environment for the analysisstore project, including a lockfile for reproducible installs and git settings to treat the lockfile as generated/binary for merges.

Changes:

  • Add pixi.toml defining a Linux conda-forge workspace, a start task, and pinned dependencies.
  • Add pixi.lock to fully lock resolved packages for reproducible environments.
  • Update .gitignore and .gitattributes to ignore local Pixi env artifacts and mark the lockfile as generated/binary-merge.
File summaries
File Description
pixi.toml Defines the Pixi workspace, task(s), and dependency constraints.
pixi.lock Adds the resolved, reproducible dependency lockfile.
.gitignore Ignores Pixi-managed environment directory contents.
.gitattributes Treats pixi.lock as generated YAML and avoids 3-way merge conflicts by using binary merge.
Review details
  • Files reviewed: 2/4 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pixi.toml
Comment thread pixi.toml Outdated
Copilot AI review requested due to automatic review settings September 4, 2026 17:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The Pixi environment pins Python to 3.11.* even though the project and CI explicitly support/test a broader Python range, reducing fidelity of the new dev environment.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

pixi.toml:12

  • pixi.toml pins Python to 3.11.*, but the project explicitly supports Python >=3.8 (setup.py) and CI tests 3.8–3.12. Pinning to a single version makes the Pixi environment less representative of the supported/tested range and can hide compatibility issues.
  • Files reviewed: 2/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants