updated name='phantom1' to name='phantom' to be able to write data to phantom asset folder - #85
Merged
Afroza Haque (Afroza-BNL) merged 2 commits intoSep 8, 2026
Conversation
… phantom asset folder
Copilot started reviewing on behalf of
Anthony Sligar (sligara7)
September 8, 2026 21:08
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small and localized, and the remaining feedback is a minor maintainability/naming consistency suggestion.
Pull request overview
This PR fixes the Phantom detector’s name so it matches the expected "phantom" asset folder, allowing data to be written to the correct location via the path provider.
Changes:
- Update
PhantomDetector(..., name=...)from"phantom1"to"phantom"in the collection profile.
File summaries
| File | Description |
|---|---|
| src/hextools/profiles/collection.py | Corrects the Phantom detector name to align with the intended assets folder/path provider behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Anthony Sligar (sligara7)
September 8, 2026 21:15
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The variable rename from phantom1 to phantom can break existing user scripts/notebooks unless a backwards-compatible alias is kept.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Afroza Haque (Afroza-BNL)
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an error in the path provider name for the phantom. phantom1 != phantom, which was the assets folder. Now updated so that path provider is phantom.