fix: replace retired NVIDIA embedding model - #901
Conversation
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Greptile SummaryThis PR replaces the retired default NVIDIA embedding model with
|
| Filename | Overview |
|---|---|
| packages/data-designer-config/src/data_designer/config/utils/constants.py | Replaces the retired NVIDIA embedding model identifier while preserving the existing embedding request parameters. |
| packages/data-designer-config/tests/config/test_default_model_settings.py | Updates the built-in model configuration assertion to match the replacement identifier. |
| fern/versions/latest/pages/concepts/models/default-model-settings.mdx | Updates the documented NVIDIA embedding default to match the built-in configuration. |
| fern/versions/latest/pages/concepts/models/model-configs.mdx | Updates the copyable embedding configuration example to use the replacement model. |
Reviews (3): Last reviewed commit: "Merge branch 'main' into andreatnvidia/f..." | Re-trigger Greptile
|
Fern preview: https://nvidia-preview-pr-901.docs.buildwithfern.com/nemo/datadesigner
|
|
Thanks for the quick turnaround on this, @andreatnvidia — unblocking the failing health check with a minimal, surgical change is exactly the right call. SummaryThis swaps the predefined NVIDIA embedding default from the retired FindingsWarnings — Worth addressing
Suggestions — Take it or leave it
Out of scope, flagging only so it isn't mistaken for coverage: What Looks Good
Structural Impact (graphify, 2.4s)Risk: MEDIUM (high-connectivity entity (NordColor, 36 deps))
High-Connectivity Changes
Cross-Package Dependencies
Reviewer note on the above: the MEDIUM rating comes from file-level attribution rather than the change itself. VerdictNeeds changes — nothing wrong with the code; the fix itself is correct and I'd merge it as-is on that basis. The one item worth resolving first:
Lint note: the dev venv wasn't present in this CI environment, so This review was generated by an AI assistant. |
|
Thanks for the focused fix, @andreatnvidia! SummaryThis updates the built-in NVIDIA embedding configuration to FindingsWarnings — Worth addressing
What Looks Good
VerdictNeeds changes — Please update the two public documentation references so the shipped default and the copyable example do not point users back to the retired model. This review was generated by an AI assistant. |
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
Updated both Fern references in |
📋 Summary
Replace DataDesigner's retired NVIDIA Build embedding default with
nvidia/nemotron-3-embed-1b. The previous model reached end of life on August 25 and now causes the scheduled provider health check to fail with HTTP 410.🔗 Related Issue
N/A
🔄 Changes
nvidia/nemotron-3-embed-1b.🧪 Testing
.venv/bin/pytest -p no:cacheprovider packages/data-designer-config/tests/config/test_default_model_settings.pynvidia/embeddingmake check-fern-docs-locally.venv/bin/ruff check --fix ..venv/bin/ruff format .✅ Checklist
Description updated with AI