feat: add safe CLI script uninstallers - #1008
Draft
bbednarski9 wants to merge 9 commits into
Draft
Conversation
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
Signed-off-by: Bryan Bednarski <bbednarski@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add supported, safety-first uninstall scripts for NeMo Relay CLI binaries installed with
install.shorinstall.ps1. The scripts provide a clean reinstall path without removing Relay configuration, output, PATH entries, or coding-agent integrations.Details
nemo-relaybinary. Preserve its installation directory, PATH changes, Relay configuration and observability output, and managed coding-agent integrations.$ErrorActionPreference = 'Stop'does not bypass dry-run or force-confirmation control flow.-Forceor-InstallDir.The change is not breaking. Existing CLI-managed integrations remain installed unless the user explicitly runs
nemo-relay uninstall allbefore removing the binary.Validation:
sh scripts/test-install.shsh scripts/test-install-mocks.shsh scripts/test-uninstall.sh— 8 groups, including active-process refusal, accepted/rejected force confirmation, process-tree termination, MCP-owner deduplication, absolute-path discovery, and self-tree refusalpwsh -NoProfile -NonInteractive -ExecutionPolicy Bypass -File scripts/test-uninstall.ps1git diff --checkCheck / Runpassed, including repository pre-commit checksclang -mthreadstoolchain issueWhere should the reviewer start?
Start with the shutdown policy in
uninstall.shanduninstall.ps1, especially MCP-owner resolution, self-tree refusal, and process-identity revalidation. Then reviewscripts/test-uninstall.shfor the destructive process-tree scenarios andscripts/test-uninstall.ps1for Windows active-process, dry-run, and confirmation coverage.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)