docs(providers): align setup guidance - #434
Conversation
Signed-off-by: Deepak Jain <deepujain@gmail.com>
8cf2c56 to
b62550f
Compare
rng1995
left a comment
There was a problem hiding this comment.
[SkillSpector Review]
The added provider setup paths otherwise match their implementations, but the table would still advertise nv_build's retired default after merging into current main. Please update that model reference so the setup documentation is actually aligned. All required checks are green.
| @@ -236,8 +236,12 @@ inference gateways. | |||
| | `anthropic_proxy` | `ANTHROPIC_PROXY_API_KEY` + `ANTHROPIC_PROXY_ENDPOINT_URL` | Any Vertex-style raw-predict proxy | `claude-sonnet-4-6` | | |||
| | `bedrock` | `AWS_PROFILE` (optional) + `AWS_REGION` — SigV4 via boto3 | AWS Bedrock Runtime | `us.anthropic.claude-sonnet-4-6-20250915-v1:0` | | |||
| | `nv_build` | `NVIDIA_INFERENCE_KEY` | build.nvidia.com | `deepseek-ai/deepseek-v4-flash` | | |||
There was a problem hiding this comment.
[P2] Update the nv_build default while aligning this table. On current main, NvBuildProvider.DEFAULT_MODEL is z-ai/glm-5.2; the old deepseek-v4-flash is explicitly retired and returns 410. This PR merges cleanly without changing this row, so the newly aligned provider table would still advertise a dead default. Change this cell to z-ai/glm-5.2 and update any copied default references.
Summary
.env.example, the README provider reference, and the development setup guide with the provider selector on currentmain.Validation
src/skillspector/providers/..env.example,README.md, anddocs/DEVELOPMENT.md.pytest -m 'not integration and not provider' tests/ -q— 2,825 passed, 13 skipped, 38 deselected, 4 xfailed.ruff check src tests— passed.ruff format --check src tests— 193 files already formatted.git diff --check— passed.Risk
Fixes #433