Fix false local references from slash-separated prose - #451
Open
Tomauskasz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tomas <tomas.bitvinskas@copla.com>
Author
|
End-to-end follow-up:
This confirms the parser change at the installed consumer boundary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reads/writesduring plain-text reference extraction../references/guide.references/guide.mdand existing Markdown destinations.Fixes #450.
Root cause
The plain relative-path pattern accepted a multi-segment token when both the explicit
./prefix and final file extension were absent. The resolver therefore could not distinguish ordinary prose from an extensionless local path.The patch requires one explicit path signal for unquoted plain-text references: an explicit
./prefix or a final extension.Verification
tests/nodes/test_security_remediation.py: 70 passed.ruff check: passed.ruff format --check: passed.git diff --check: passed.n8n-post-change-runtime-proofcompleted with 100% coverage, zero unresolved references, andanalysis_completeness.is_complete: true.Tradeoff
An unquoted extensionless token such as
references/guideis ambiguous with prose. Authors must use./references/guide, Markdown link syntax, or an extension-bearing path.AI assistance disclosure
Codex inspected the reference resolver, reproduced the defect, drafted the implementation and tests, and ran the verification commands. I reviewed the root cause, diff, behavior, tradeoff, and final pull-request text.