Skip to content

[JAX] Remove duplicate score-mod test run - #3524

Open
KshitijLakhani wants to merge 1 commit into
NVIDIA:mainfrom
KshitijLakhani:klakhani/fix/duplicate-score-mod-tests-in-ci
Open

KshitijLakhani wants to merge 1 commit into
NVIDIA:mainfrom
KshitijLakhani:klakhani/fix/duplicate-score-mod-tests-in-ci

Conversation

@KshitijLakhani

@KshitijLakhani KshitijLakhani commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Description

Remove duplicate tests runs in CI for score mod as correctly reported by @kainzhong
The former covers the score mod tests already and an explicit call should not be needed for it


python3 -m pytest -c $TE_PATH/tests/jax/pytest.ini -v --junitxml=$XML_LOG_DIR/pytest_jax_not_distributed.xml $TE_PATH/tests/jax --ignore=$TE_PATH/tests/jax/test_multi_process_ep.py -k 'not distributed' || test_fail "tests/jax/*not_distributed_*"
python3 -m pytest -c $TE_PATH/tests/jax/pytest.ini -v --junitxml=$XML_LOG_DIR/pytest_jax_fused_attn_score_mod.xml $TE_PATH/tests/jax/test_fused_attn_score_mod.py || test_fail "tests/jax/test_fused_attn_score_mod.py"

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Kshitij Lakhani <klakhani@nvidia.com>
@KshitijLakhani

Copy link
Copy Markdown
Collaborator Author

/te-ci jax

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because it removes only a duplicate invocation without reducing score-mod test coverage or failure propagation.

Summary

This PR removes a redundant dedicated JAX score-mod pytest invocation from the L0 QA script.

  • The preceding non-distributed JAX suite already collects and executes the score-mod test module.
  • Score-mod failures remain represented in JUnit output and propagate through the existing failure aggregation.

Reviews (1) · Last reviewed commit: "Remove duplicate JAX score-mod test run"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant