Avoid absolute generated source paths in cuda.core builds - #2720
Draft
rwgk wants to merge 1 commit into
Draft
Conversation
rwgk
added
CI/CD
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 0ba000b |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #2472.
PR #2472 correctly placed Cython-generated sources in a CUDA-major-keyed directory anchored to the checkout. Cython then returns those generated C++ source paths as absolute paths. When setuptools maps an absolute source into
build/temp, it reproduces the checkout path beneath that directory; sufficiently deep Windows worktrees can therefore exceed the linker path limit.This change converts absolute extension source paths to paths relative to the project root after
cythonize()returns. It preserves the anchored, CUDA-major-keyed generated-source cache from #2472, while preventing setuptools from embedding the full checkout path in its temporary object and linker output paths. Existing relative C++ source paths remain unchanged.Verification
SKIP=lychee pre-commit run --all-filesTestVenv/bin/python -m pytest cuda_core/tests/test_build_hooks.py -v --noconftest(24 passed)qa/runbook/qa_bindings_linux_build.sh 13.3Checklist