Fix the lychee precommit hook - #2729
Merged
Merged
Conversation
Contributor
Author
|
The reason we didn't catch this in CI is because the pre-commit CI caches its environment based on our |
seberg
approved these changes
Aug 28, 2026
seberg
left a comment
seberg
left a comment
Contributor
There was a problem hiding this comment.
Weird need, but clearly OK to do.
mdboom
enabled auto-merge (squash)
August 28, 2026 14:20
This comment has been minimized.
This comment has been minimized.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lychee precommit hook (which is independently released from lychee itself) recently changed behavior where it needs an actual lychee version, but it converts the hash to a rev using /our/ tags rather than it's own.
Fortunately, we can override this behavior with an environment variable, so the workaround is not to bad and does not reduce the security benefits of hash-pinning.