Fix #2725: Add temporary shims for old cuda_bindings._test_helpers - #2731
Open
mdboom wants to merge 3 commits into
Open
Fix #2725: Add temporary shims for old cuda_bindings._test_helpers#2731mdboom wants to merge 3 commits into
mdboom wants to merge 3 commits into
Conversation
github-actions
Bot
added
CI/CD
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎶 IMPORTANT NOTE: This whole issue will naturally disappear at the next
cuda-corerelease. We should confirm it's worth merging this and removing it later vs. just waiting.Since the bug appears only in nightly CI runs, this was specially tested here, and it fixes the two affected jobs:
This is complex -- we need to actually import two different versions of
cuda_python_test_helperssimultaneously -- the one expected bycuda-core-1.1.1and the one expected bycuda-bindingsmain. This reveals perhaps a fundamental problem with the design ofcuda_python_test_helpersthat should be addressed in a follow-up but this papers over the nightly tests for now so that we get actual compatibility testing betweencuda-core [latest release]andcuda-bindings [main].(It does not fix the other subissues of #2722).