Fix maximum_active_blocks wrappers passing int to CudaHostAdapter* - #3638
Open
chrisXYZhang wants to merge 2 commits into
Open
chrisXYZhang wants to merge 2 commits into
chrisXYZhang wants to merge 2 commits into
Conversation
Six 2.x device wrappers forwarded an int argument to GemmUniversalBase::maximum_active_blocks(), which now expects CudaHostAdapter*. Comment out the unused parameter name and call without forwarding so it picks up the default nullptr. The column-major specialisations of RankK, Rank2K, and Symm forwarded to primaries that never defined maximum_active_blocks, making them dead code. Remove them rather than adding a new API. Fixes NVIDIA#3534
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intargument toGemmUniversalBase::maximum_active_blocks(), which changed its parameter toCudaHostAdapter*in CUTLASS 3.4. This causes a compilation error. Fixed by commenting out the unused parameter name and calling without forwarding, so it picks up the defaultnullptr.RankK,Rank2K, andSymmforwarded to primaries that never definedmaximum_active_blocks(), making them dead code. Removed them rather than adding a new API to the primaries. Happy to take a different direction if maintainers prefer adding the query instead.Files changed
Signature fix (6 files):
include/cutlass/gemm/device/gemm_universal.hinclude/cutlass/gemm/device/gemm_universal_with_broadcast.hinclude/cutlass/gemm/device/gemm_universal_streamk_with_broadcast.hinclude/cutlass/gemm/device/gemm_universal_with_absmax.hinclude/cutlass/gemm/device/gemm_with_k_reduction.hinclude/cutlass/gemm/device/gemm_layernorm_mainloop_fusion.hDead forwarder removal (3 files):
include/cutlass/gemm/device/rank_k.hinclude/cutlass/gemm/device/rank_2k.hinclude/cutlass/gemm/device/symm.hTest plan
Fixes #3534