Skip to content

tests(core): move dpu_info_list to integration suite - #5548

Merged
poroh merged 1 commit into
NVIDIA:mainfrom
poroh:tests-dpu-info-list
Aug 31, 2026
Merged

tests(core): move dpu_info_list to integration suite#5548
poroh merged 1 commit into
NVIDIA:mainfrom
poroh:tests-dpu-info-list

Conversation

@poroh

@poroh poroh commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Straight forward move of tests to integration suite.

Related issues

#2001

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@poroh
poroh requested a review from a team as a code owner August 29, 2026 00:44
@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6cdea3ef-d53f-4fad-8669-8e2c42b675f0

📥 Commits

Reviewing files that changed from the base of the PR and between 0cd6700 and f68215d.

📒 Files selected for processing (2)
  • crates/api-core/src/tests/mod.rs
  • crates/api-core/tests/integration/main.rs
💤 Files with no reviewable changes (1)
  • crates/api-core/src/tests/mod.rs

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Summary by CodeRabbit

  • Tests
    • Updated DPU information list integration coverage to use the current test setup and API access patterns.
    • Verified DPU loopback address retrieval through managed host data.
    • Registered the integration test in the main test suite.

Walkthrough

The DPU information integration test now creates its environment through TestHarness, retrieves host data through managed-host objects, uses updated API accessors, and is registered from the integration test module.

Changes

DPU information integration test

Layer / File(s) Summary
Test harness setup and host data retrieval
crates/api-core/tests/integration/dpu_info_list.rs
The test creates network and managed-host resources through TestHarness. It uses .api() accessors and retrieves DPU loopback addresses asynchronously from managed-host machine objects.
Integration module registration
crates/api-core/tests/integration/main.rs, crates/api-core/src/tests/mod.rs
The test is registered in the integration test entry point and removed from the API core test declarations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f6821

This change relocates tests into the integration suite without changing product behavior, and no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description accurately states that the tests moved to the integration suite and identifies the change as internal test maintenance.
Title check ✅ Passed The title clearly and concisely describes the main change: moving dpu_info_list tests to the integration suite.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
@poroh
poroh force-pushed the tests-dpu-info-list branch from 0cd6700 to f68215d Compare August 29, 2026 15:34
@github-actions

Copy link
Copy Markdown

@poroh
poroh merged commit 845ccf0 into NVIDIA:main Aug 31, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants