Skip to content

patch(v2.1): Drop stale port 7777 from default phone-home URL - #5565

Closed
kfelternv wants to merge 1 commit into
NVIDIA:release/v2.1from
kfelternv:backport-5156-v2.1
Closed

patch(v2.1): Drop stale port 7777 from default phone-home URL#5565
kfelternv wants to merge 1 commit into
NVIDIA:release/v2.1from
kfelternv:backport-5156-v2.1

Conversation

@kfelternv

Copy link
Copy Markdown
Contributor

This backport removes the obsolete port 7777 from the default REST phone-home URL and removes stale NICo-authored phone-home blocks when phone-home is disabled. It preserves caller-supplied callbacks and applies the same behavior to single-instance, batch-instance, and operating-system request paths.

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Passed focused race-enabled and full changed-package tests, Go vet and lint checks, OpenAPI validation and SDK regeneration, and documentation validation.

Additional Notes

No runtime DevSpace verification was performed.

Signed-off-by: Kyle Felter <kfelter@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@thossain-nv thossain-nv added the rest-api Add this label when an issue or PR concerns NICo REST API label Aug 31, 2026 — with ChatGPT Codex Connector
@kfelternv kfelternv closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rest-api Add this label when an issue or PR concerns NICo REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants