test: drop shadowed ignoreAttributes option - #863
Open
rajanpanth wants to merge 1 commit into
Open
Conversation
The object literal set ignoreAttributes twice; the boolean was immediately overridden by the function and never took effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec/pathExpression_spec.jssetsignoreAttributestwice in the same object literal:The later function wins, so the boolean never reaches the parser. esbuild flags it as
duplicate-object-key, and most lint configs would too.The test still passes for the right reason today, since the function is what the spec is about. The risk is the reverse reading: the literal looks like it exercises
ignoreAttributes: falsealongside the function, so anyone later removing the function would assume boolean behaviour was still covered here when it never was.Removing the dead line only. 21 specs in the file pass, and the esbuild duplicate-key warning is gone.
Modest severity, flagging that honestly — it's dead code in a test rather than a behaviour bug.