Fixing uncataloged issue && copyright/SPDX headers - #72
Conversation
|
Thanks for your first PR to Pace — welcome aboard. Quick orientation:
For background, see CONTRIBUTING.md. |
|
Test Report missing or unfilled. This PR touches This is a soft gate - your CI checks are unaffected - but reviewers will not approve until the report is filled in. |
A CI check failed — here is how to fix itWorkflow: PR Guard · Run #138 · Failed jobs: 1 commitlintCommit message does not follow Conventional Commits. Required format: Valid types: To rewrite the last commit: git commit --amend -m "feat(python): your description"
git push --force-with-leasePush a fix and CI re-runs automatically; this comment updates with the next failure (or stays put if the same check fails again). Stuck? Comment on the PR and a maintainer will help — typical response time is 1 business day. Auto-generated · explain-failure.yml |
hvinn
left a comment
There was a problem hiding this comment.
Approving — the catalog registration and copyright/SPDX header fixes correctly resolve the gaps from #71 (validate-and-lint now passes).
Non-blocking follow-ups worth a look before/after merge:
commitlintis failing on the commit message (no Conventional Commits type/scope) — consider amending.playbooks/user_registration.ymladds adebugtask that echoesncl_access_tokenin plaintext withoutno_log: true, unlike every other auth task in this feature — recommend guarding it.- 21 files got their mode flipped to
100755(executable) — likely an editor artifact, probably worth reverting to100644. Ansible — syntax & lintand the CodeQL/go-vet 429s are unrelated infra flakiness/pre-existing issues, not blockers on this PR.
Summary
Changes
Checklist
General
<tool>/<product>/(e.g.python/ontap/), not at the tool rootcatalog.yaml— includingproduct— and the product README for new/changed examples (see CONTRIBUTING.md)If touching
python/python -m py_compile python/*/*.py)ruff check python/)If touching
ansible/ansible-playbook --syntax-check)ansible-lintpassesIf touching
terraform/terraform fmt -checkpassesterraform validatepassesIf touching
go/go vet ./...passes (fromgo/directory)go build -o /dev/null .passes for the changed programTest Report
Environment:
Platform version:
Style touched:
First run
Command + output
Idempotency / re-run
Second-run evidence
Cleanup / teardown
Teardown evidence (skip for read-only examples)
Cannot run on a cluster?
Related issues