@iloveitaly we're thinking of patching this but wanted some feedback first. actions like search and get_list use a pattern of "if success? else return false" where success is typically defined as response_hash[:status][:@is_success] == 'true' but we find transient errors in both the above methods so suspect they are 5xx that should be retried. since the response isn't returned we haven't actually captured one.
Proposal:
- add a raise_on_failed_response option to NetSuite.configure that raises Netsuite::FailedResponseError < StandardError which includes a response accessor
- retry these for now from backoff, ideally identify only the transient ones to retry in the future
@iloveitaly we're thinking of patching this but wanted some feedback first. actions like search and get_list use a pattern of "if success? else return false" where success is typically defined as response_hash[:status][:@is_success] == 'true' but we find transient errors in both the above methods so suspect they are 5xx that should be retried. since the response isn't returned we haven't actually captured one.
Proposal: