Rule Dash Permission Fixes - #4385
Draft
cielbellerose wants to merge 16 commits into
Draft
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updating rule dash permissions
Todo
Updated Permissions
✅ Allowed
🟪 Update to add permissions?
Test Cases
access denied when members try to create rules
leadership and above can create rules
rule status update fails if member is not on project team
status update fails for member trying to update general view status
rule status update works if member is on project team
delete ruleset succeeds if leadership created the ruleset
delete ruleset fails if leadership was not creator
access denied if member tries to assign rules to teams
guests cannot get rules (top level & all for ruleset)
Screenshots
Guest View

Member View


** Member View (not their teams project) **

Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4384