Skip to content

Edit Event Includes Rescheduling Time - #4397

Open
glickgNU wants to merge 1 commit into
developfrom
#4386-edit-event-includes-rescheduling-time
Open

Edit Event Includes Rescheduling Time #4397
glickgNU wants to merge 1 commit into
developfrom
#4386-edit-event-includes-rescheduling-time

Conversation

@glickgNU

Copy link
Copy Markdown
Contributor

Changes

Changed EventModal.tsx and EditEventModal.tsx to allow for the edit event feature to modify time.

Notes

A default zoom link value issue was also fixed. A default zoom link will not be applied to event types with no zoom links.

Test Cases

  • Made an event with required members for a certain time. Could reschedule it. Tested event types: Manufacturing, Misc Event, FHE, Deadline/Heads up, FSAE

To Do

Any remaining things that need to get done

  • item 1
  • ...

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4386

@staysgt staysgt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it so that we are also able to reschedule event types that requireConfirmation once they have already been scheduled? Ie the Misc Event When2Meet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintenance] - Edit Event Includes Rescheduling Time

2 participants