[MIG] sale_margin_delivery_cost: Migration to 19.0 - #280
Open
dreispt wants to merge 7 commits into
Open
Conversation
OCA-git-bot
added
series:19.0
mod:sale_margin_delivery_cost
devin-ai-integration
Bot
force-pushed
the
19.0-mig-sale_margin_delivery_cost
branch
from
August 18, 2026 09:37
a0d993c to
b08ee5d
Compare
Port sale_margin_delivery_cost from 16.0 to 19.0. Migration changes: - Update the Sale Order view to use <list> and the Odoo 17+ readonly expression syntax. - Replace the deprecated product type exclusion domain with the current product type selection values. Assisted-by: Devin:SWE-1.7
Add tests covering: - margin computation with other costs - set_delivery_line for "other" charging policy - set_delivery_line for "sale" charging policy Assisted-by: Devin:SWE-1.7
devin-ai-integration
Bot
force-pushed
the
19.0-mig-sale_margin_delivery_cost
branch
from
August 18, 2026 10:46
b08ee5d to
7c39ebc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This migrates
sale_margin_delivery_costfrom 16.0 to 19.0.Migration changes:
sale.orderform view to use<list>and the Odoo 17+readonlyexpression syntax (replacing<tree>andattrs).('type', '!=', 'product')product domain with the current product type selection values('type', 'in', ('consu', 'service')).Assisted-by: Devin:SWE-1.7