#14622 Sector export: Preserve separate include files for ACTNUM and … - #14624
Open
kriben wants to merge 1 commit into
Open
#14622 Sector export: Preserve separate include files for ACTNUM and …#14624kriben wants to merge 1 commit into
kriben wants to merge 1 commit into
Conversation
…FAULTS Sector model export removed all ACTNUM and FAULTS keywords from the deck and re-inserted the sector-specific replacements at the end of the GRID section, which always lands in the main DATA file. Decks that keep these keywords in separate include files lost their file organization, leaving the original include files empty while the data was written inline. Collapse duplicates to a single occurrence instead of removing all occurrences, so the subsequent in-place replacement keeps the keyword in its original file when the deck is saved with OutputMode::COPY. ACTNUM keeps the last occurrence since a later ACTNUM overrides an earlier one; FAULTS keeps the first so fault definitions do not move past keywords referencing them.
jonjenssen
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…FAULTS
Sector model export removed all ACTNUM and FAULTS keywords from the deck and re-inserted the sector-specific replacements at the end of the GRID section, which always lands in the main DATA file. Decks that keep these keywords in separate include files lost their file organization, leaving the original include files empty while the data was written inline.
Collapse duplicates to a single occurrence instead of removing all occurrences, so the subsequent in-place replacement keeps the keyword in its original file when the deck is saved with OutputMode::COPY. ACTNUM keeps the last occurrence since a later ACTNUM overrides an earlier one; FAULTS keeps the first so fault definitions do not move past keywords referencing them.
Fixes #14622.