MSW export: Report a grid cell only once in COMPSEGS - #14647
Open
magnesj wants to merge 5 commits into
Open
Conversation
… legacy projects Reverts the unconditional change from commit 74ffc82 and replaces it with a safer fix: only skip re-initializing the well path name from the source file on reload when a name has already been set. Older projects that never serialized the well path Name field (e.g. TestCase_RFT_PLT/RegressionTest.rsp) still get their name populated from the file on load, while renamed well paths in newer projects keep their custom name across reloads. Restores the RMS well round-trip test that verifies a renamed well path name persists after save/reopen.
When creating a histogram from grid cell results (e.g. PERMX) via "Create Grid Statistics Plot", zoom the histogram plot to fit the data right after the curve is populated, instead of leaving it at default axis ranges.
Selecting a curve or a plot inside a RimHistogramMultiPlot in the project tree now scrolls the multi plot view to make the containing histogram plot visible, mirroring the existing behavior for RimSummaryMultiPlot.
A grid cell has a single COMPDAT connection and must be connected to exactly one segment, but the geometry-based export emitted one COMPSEGS row per branch intersecting the cell. Restore the well-global bookkeeping the removed tree path had: tag each branch with its origin and let the branch carrying most flow claim a shared cell, perforations before fishbones before fractures.
The branch number of a fracture followed the order the fractures were created, so appending a second set of fractures to a well put them after the existing ones regardless of where along the well they sit. Sort by the fracture start MD instead. The order also decides which fracture connects a grid cell shared by two of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14646
Stacked on #14644 — the first three commits belong to that PR.
Report a grid cell only once across COMPSEGS branches. A cell has a single COMPDAT connection and must be connected to exactly one segment, but the export emitted one COMPSEGS row per branch intersecting the cell. The tree path kept a well-global set of connected cells, ordered perforations, fishbones, fractures; that was lost when the tree path was removed in 313ed1e.
RigMswBranchnow carries aRigMswBranchSource, andcollectTableData()keeps the first claim on each(gridName, i, j, k)in that priority order.Number fracture branches by measured depth.
buildFractureBranches()followed collection order, so fractures appended to a well were numbered after the existing ones no matter where along the well they sit. They are now sorted by fracture start MD, which also decides which fracture connects a shared cell.