Well target mapping: Fix crashes from invalid bounds and missing result data - #14650
Merged
Conversation
…unds std::clamp() invokes undefined behavior when the low bound is greater than the high bound. In resetMinimumCellValuesToDefault(), the minimum/maximum bounds for saturation, pressure, permeability and transmissibility are derived from case data and can end up inverted when no data is available, which crashed or produced garbage values.
…or incomplete result data RigWellTargetMappingTools accessed cellScalarResults() and result vectors without verifying the requested time step or index was within bounds, and without checking for null case data pointers. Add the missing guards.
jonjenssen
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two crash-prone spots in well target mapping:
Both add defensive checks and fall back to safe defaults instead of crashing.
Seen when using test dataset from https://github.com/CeetronSolutions/resinsight-tutorials/tree/main/model-data/grid_ensemble