Skip to content

Add memory option to script - #970

Open
Bubballoo3 wants to merge 7 commits into
masterfrom
add-memory-to-script-952
Open

Add memory option to script#970
Bubballoo3 wants to merge 7 commits into
masterfrom
add-memory-to-script-952

Conversation

@Bubballoo3

@Bubballoo3 Bubballoo3 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a memory option to the script option to request memory-per-node in MiB. Adds support for this attribute in the slurm adapter

Related issue

Fixes #952

Testing

  • Tests included
  • No tests needed — reason: ___

Checklist

  • Follows project code style and conventions
  • Documentation provided (if new feature, adapter or behavior change)
  • This is a large feature and was discussed in an issue first (if applicable)

Anything else?

Still exploring documentation for other schedulers, so that will be incoming soon

@johrstrom

Copy link
Copy Markdown
Contributor

Still exploring documentation for other schedulers, so that will be incoming soon

https://slurm.schedmd.com/rosetta.pdf

johrstrom
johrstrom previously approved these changes Sep 3, 2026

@johrstrom johrstrom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://exaworks.org/psij-python/docs/v/0.9.10/.generated/index.html#resourcespecv1 as a reference for these changes. It only accepts memory as an integer number of bytes, which is why the helper method is required to take it from MiB to bytes

Add comments to clarify memory conversion method
@Bubballoo3

Copy link
Copy Markdown
Contributor Author

@johrstrom I think I have hit all the schedulers, but let me know if I am missing any that I should add. I currently have everything on the RosettaStone doc except LoadLeveler (which doesn't have a scheduler?) plus PSIJ. Adding Fujitsu would be nice but I haven't found docs anywhere and the link from @mnakao in #851 (comment) is no longer valid. But if you agree, I think this has enough breadth to move forward on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Universal memory attribute on scripts

2 participants